Hi, On Tuesday 19 February 2008, Ivo van Doorn wrote: > Hi, > [...] > > > > I've tried the patch but, unfortunately, my wireless LAN still dies after a few pings. > > Could you use below patch instead, and make a new dump of the register? > I'm still convinced the breakage occurs in the antenna diversity (or rather, I believe > it attempts a software diversity for your card while in fact it shouldn't). > Sorry, I've applied that patch and the LAN still dies after a few pings. BTW, this and the earlier patch both apply without error, but give warnings of 70 line offsets. Were you expecting them to apply completely cleanly? I'm just wondering if there might be some code that you are expecting to be running (or not running) that is (or is not) present in the driver at 2.6.25-rc2. The register dumps before and after are attached. Thanks, Chris > > The frame dump diagnostics you asked for are attached. This is a fresh dump taken > > tonight running the driver with your patch applied. > > Thanks, I think I miss some information in that dump, > but that is okay for now. > > Ivo > > --- > > diff --git a/drivers/net/wireless/rt2x00/rt2x00dev.c b/drivers/net/wireless/rt2x00/rt2x00dev.c > index 015738a..65a512f 100644 > --- a/drivers/net/wireless/rt2x00/rt2x00dev.c > +++ b/drivers/net/wireless/rt2x00/rt2x00dev.c > @@ -223,7 +223,7 @@ static void rt2x00lib_evaluate_antenna_eval(struct rt2x00_dev *rt2x00dev) > * sample the rssi from the other antenna to make a valid > * comparison between the 2 antennas. > */ > - if ((rssi_curr - rssi_old) > -5 || (rssi_curr - rssi_old) < 5) > + if (abs(rssi_curr - rssi_old) < 5) > return; > > rt2x00dev->link.ant.flags |= ANTENNA_MODE_SAMPLE; > @@ -249,10 +249,10 @@ static void rt2x00lib_evaluate_antenna(struct rt2x00_dev *rt2x00dev) > rt2x00dev->link.ant.flags &= ~ANTENNA_TX_DIVERSITY; > > if (rt2x00dev->hw->conf.antenna_sel_rx == 0 && > - rt2x00dev->default_ant.rx != ANTENNA_SW_DIVERSITY) > + rt2x00dev->default_ant.rx == ANTENNA_SW_DIVERSITY) > rt2x00dev->link.ant.flags |= ANTENNA_RX_DIVERSITY; > if (rt2x00dev->hw->conf.antenna_sel_tx == 0 && > - rt2x00dev->default_ant.tx != ANTENNA_SW_DIVERSITY) > + rt2x00dev->default_ant.tx == ANTENNA_SW_DIVERSITY) > rt2x00dev->link.ant.flags |= ANTENNA_TX_DIVERSITY; > > if (!(rt2x00dev->link.ant.flags & ANTENNA_RX_DIVERSITY) && > > -- Beauty is in the eye of the beerholder.