mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: lkml <linux-kernel@vger.kernel.org>, akpm <akpm@linux-foundation.org>
Subject: Re: [PATCH] documentation: fix firmware_sample_firmware_class to build
Date: Tue, 19 Feb 2008 22:46:42 -0800	[thread overview]
Message-ID: <20080220064642.GA22884@kroah.com> (raw)
In-Reply-To: <20080218162216.ee1501fd.randy.dunlap@oracle.com>

On Mon, Feb 18, 2008 at 04:22:16PM -0800, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> Fix firmware_sample_firmware_class module to build without error.
> sysfs.h already has the function prototypes and has them correctly.
> 
> Documentation/firmware_class/firmware_sample_firmware_class.c:37: error: conflicting types for 'sysfs_remove_bin_file'
> include/linux/sysfs.h:100: error: previous declaration of 'sysfs_remove_bin_file' was here
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
>  Documentation/firmware_class/firmware_sample_firmware_class.c |    3 ---
>  1 file changed, 3 deletions(-)

Can we move this file to the samples/ directory, so the build will catch
stuff like this?

What's the final version of this patch?

thanks,

greg k-h

  parent reply	other threads:[~2008-02-20  6:50 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-19  0:22 Randy Dunlap
2008-02-19  0:32 ` David Rientjes
2008-02-19  0:51   ` David Rientjes
2008-02-19 22:40     ` Randy Dunlap
2008-02-20  1:39       ` [patch] sysfs: small header file cleanup David Rientjes
2008-02-20  4:17         ` Randy Dunlap
2008-02-20  6:46 ` Greg KH [this message]
2008-02-20 20:10   ` [PATCH] documentation: fix firmware_sample_firmware_class to build Randy Dunlap
2008-02-20 20:40     ` Greg KH
2008-02-20 21:20       ` [PATCH 1/2] firmware: move firmware_class from Documentation/ to samples/ Randy Dunlap
2008-02-20 21:48         ` Marcel Holtmann
2008-02-21  0:07         ` patch firmware-move-firmware_class-from-documentation-to-samples.patch added to gregkh-2.6 tree gregkh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080220064642.GA22884@kroah.com \
    --to=greg@kroah.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome