From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934531AbYBTUmr (ORCPT ); Wed, 20 Feb 2008 15:42:47 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933488AbYBTUmT (ORCPT ); Wed, 20 Feb 2008 15:42:19 -0500 Received: from pentafluge.infradead.org ([213.146.154.40]:39860 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933162AbYBTUmS (ORCPT ); Wed, 20 Feb 2008 15:42:18 -0500 Date: Wed, 20 Feb 2008 12:40:01 -0800 From: Greg KH To: Randy Dunlap Cc: lkml , akpm Subject: Re: [PATCH] documentation: fix firmware_sample_firmware_class to build Message-ID: <20080220204001.GB15787@kroah.com> References: <20080218162216.ee1501fd.randy.dunlap@oracle.com> <20080220064642.GA22884@kroah.com> <47BC893C.6060309@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <47BC893C.6060309@oracle.com> User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 20, 2008 at 12:10:36PM -0800, Randy Dunlap wrote: > Greg KH wrote: >> On Mon, Feb 18, 2008 at 04:22:16PM -0800, Randy Dunlap wrote: >>> From: Randy Dunlap >>> >>> Fix firmware_sample_firmware_class module to build without error. >>> sysfs.h already has the function prototypes and has them correctly. >>> >>> Documentation/firmware_class/firmware_sample_firmware_class.c:37: error: >>> conflicting types for 'sysfs_remove_bin_file' >>> include/linux/sysfs.h:100: error: previous declaration of >>> 'sysfs_remove_bin_file' was here >>> >>> Signed-off-by: Randy Dunlap >>> --- >>> Documentation/firmware_class/firmware_sample_firmware_class.c | 3 --- >>> 1 file changed, 3 deletions(-) >> Can we move this file to the samples/ directory, so the build will catch >> stuff like this? >> What's the final version of this patch? > > I've moved it to samples/, but it (still) has a build problem: > > ERROR: "firmware_class" > [samples/firmware_class/firmware_sample_firmware_class.ko] undefined! > > Can you give me hint(s) about how to fix that? Ah, yeah, that class went away a while ago. Care to send me the patch you have, and I'll be glad to fix it up and get it in? thanks, greg k-h