From: gstreiff@neteffect.com
To: rdreier@cisco.com
Cc: flatif@neteffect.com, general@lists.openfabrics.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 2.6 6/8] RDMA/nes: Fix rdma connection establishment on big-endian platforms
Date: Thu, 21 Feb 2008 08:29:41 -0600 [thread overview]
Message-ID: <200802211429.m1LETfLj005153@velma.neteffect.com> (raw)
From: Faisal Latif <flatif@neteffect.com>
With commit ef19454bd437b2ba, behavior of crc32c changes on
big-endian platforms.
Our algorithm expects previous behavior otherwise we have
rdma connection establishment failure on big-endian platforms
like ppc64. Applying cpu_to_le32() to value returned by
crc32c() to get previous behavior.
Signed-off-by: Faisal Latif <flatif@neteffect.com>
Signed-off-by: Glenn Streiff <gstreiff@neteffect.com>
---
drivers/infiniband/hw/nes/nes.h | 14 ++++++++++++++
drivers/infiniband/hw/nes/nes_cm.c | 5 +++--
2 files changed, 17 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/hw/nes/nes.h b/drivers/infiniband/hw/nes/nes.h
index fd57e8a..b0d3c52 100644
--- a/drivers/infiniband/hw/nes/nes.h
+++ b/drivers/infiniband/hw/nes/nes.h
@@ -285,6 +285,20 @@ struct nes_device {
};
+static inline u32 get_crc_value(struct nes_v4_quad* nes_quad)
+{
+ u32 crc_value;
+ crc_value = crc32c(~0, (void *)nes_quad, sizeof (struct nes_v4_quad));
+
+ /*
+ * With commit ef19454bd437b2ba, behavior of crc32c changes on
+ * big-endian platforms. Our algorithm expects previous behavior
+ * otherwise we have rdma connection establishment issue on ppc64.
+ */
+ crc_value = cpu_to_le32(crc_value);
+ return crc_value;
+}
+
static inline void
set_wqe_64bit_value(__le32 *wqe_words, u32 index, u64 value)
{
diff --git a/drivers/infiniband/hw/nes/nes_cm.c b/drivers/infiniband/hw/nes/nes_cm.c
index 6c298aa..1f042d1 100644
--- a/drivers/infiniband/hw/nes/nes_cm.c
+++ b/drivers/infiniband/hw/nes/nes_cm.c
@@ -2320,6 +2320,7 @@ int nes_accept(struct iw_cm_id *cm_id, struct iw_cm_conn_param *conn_param)
struct iw_cm_event cm_event;
struct nes_hw_qp_wqe *wqe;
struct nes_v4_quad nes_quad;
+ u32 crc_value;
int ret;
ibqp = nes_get_qp(cm_id->device, conn_param->qpn);
@@ -2436,8 +2437,8 @@ int nes_accept(struct iw_cm_id *cm_id, struct iw_cm_conn_param *conn_param)
nes_quad.TcpPorts[1] = cm_id->local_addr.sin_port;
/* Produce hash key */
- nesqp->hte_index = cpu_to_be32(
- crc32c(~0, (void *)&nes_quad, sizeof(nes_quad)) ^ 0xffffffff);
+ crc_value = get_crc_value(&nes_quad);
+ nesqp->hte_index = cpu_to_be32(crc_value ^ 0xffffffff);
nes_debug(NES_DBG_CM, "HTE Index = 0x%08X, CRC = 0x%08X\n",
nesqp->hte_index, nesqp->hte_index & adapter->hte_index_mask);
next reply other threads:[~2008-02-21 13:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-21 14:29 gstreiff [this message]
2008-02-21 13:46 ` [ofa-general] [PATCH 2.6 6/8] RDMA/nes: Fix rdma connectionestablishment " Glenn Streiff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802211429.m1LETfLj005153@velma.neteffect.com \
--to=gstreiff@neteffect.com \
--cc=flatif@neteffect.com \
--cc=general@lists.openfabrics.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®