From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: "Ray Lee" <ray-lk@madrabbit.org>
Cc: "Greg KH" <gregkh@suse.de>, "Adrian Bunk" <bunk@kernel.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: usb/serial/io_ti.c: inconsequent NULL checking
Date: Fri, 22 Feb 2008 10:10:16 +0000 [thread overview]
Message-ID: <20080222101016.37128803@core> (raw)
In-Reply-To: <2c0942db0802191538k79f93ca5p93a1883a449f3bb0@mail.gmail.com>
> Either the test of port->tty here is unneeded:
>
> if (port->tty)
> port->tty->low_latency = low_latency;
>
> ...or the lack of test of port->tty here is a mistake:
>
> edge_set_termios (port, port->tty->termios);
Interesting - so coverity doesn't understand the BKL. It's producing the
right answer, for the right reason but the assumption it makes isn't 100%
safe.
The check can go.
Alan
next prev parent reply other threads:[~2008-02-22 10:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-19 22:49 Adrian Bunk
2008-02-19 23:25 ` Greg KH
2008-02-19 23:38 ` Ray Lee
2008-02-22 10:10 ` Alan Cox [this message]
2008-02-22 19:58 ` [2.6 patch] usb/serial/io_ti.c: remove unneeded NULL check Adrian Bunk
2008-02-22 19:56 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080222101016.37128803@core \
--to=alan@lxorguk.ukuu.org.uk \
--cc=bunk@kernel.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ray-lk@madrabbit.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®