From: David Brownell <david-b@pacbell.net>
To: cbouatmailru@gmail.com
Cc: Andrew Morton <akpm@linux-foundation.org>,
Florian Fainelli <florian.fainelli@telecomint.eu>,
linux-kernel@vger.kernel.org, hpa@zytor.com, tglx@linutronix.de,
Ingo Molnar <mingo@elte.hu>,
Mauro Carvalho Chehab <mchehab@infradead.org>
Subject: Re: [PATCH 1/4 resend] [x86] Add generic GPIO support to x86
Date: Fri, 22 Feb 2008 16:51:30 -0800 [thread overview]
Message-ID: <200802221651.31216.david-b@pacbell.net> (raw)
In-Reply-To: <20080222235628.GA31683@zarina>
On Friday 22 February 2008, Anton Vorontsov wrote:
> > +static inline int gpio_request(unsigned gpio, const char *label)
> > +{
> > + return -EINVAL;
>
> Could we return -ENOSYS instead, so drivers will able to distinguish
> between "something really failed" and "there is no gpio support,
> fallback to other methods"? Without this, the notorious NAND driver
> will hardly benefit from this change. ;-)
Sure; that'll be gpio_request() and the gpio_direction_*() calls only
though, since those are the initial setup calls drivers make.
- Dave
prev parent reply other threads:[~2008-02-23 0:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-18 13:51 Florian Fainelli
2007-10-18 21:38 ` Andres Salomon
2007-10-19 12:01 ` Florian Fainelli
2007-10-19 21:32 ` Jordan Crouse
2007-10-21 16:06 ` Haavard Skinnemoen
2007-10-22 19:18 ` Andres Salomon
2007-10-22 19:59 ` Florian Fainelli
2007-10-25 8:18 ` Thomas Gleixner
2007-10-25 12:30 ` Florian Fainelli
2007-10-25 15:24 ` Thomas Gleixner
2008-02-13 22:02 ` Andrew Morton
2008-02-13 23:25 ` David Brownell
2008-02-14 1:55 ` David Brownell
2008-02-22 23:56 ` Anton Vorontsov
2008-02-23 0:51 ` David Brownell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802221651.31216.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=akpm@linux-foundation.org \
--cc=cbouatmailru@gmail.com \
--cc=florian.fainelli@telecomint.eu \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome