mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Kohei KaiGai <kaigai@ak.jp.nec.com>
Cc: morgan@kernel.org, serue@us.ibm.com,
	linux-security-module@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] exporting capability name/code pairs (final)
Date: Fri, 22 Feb 2008 09:04:59 -0800	[thread overview]
Message-ID: <20080222170459.GB18524@kroah.com> (raw)
In-Reply-To: <47BE2A26.1080806@ak.jp.nec.com>

On Fri, Feb 22, 2008 at 10:49:26AM +0900, Kohei KaiGai wrote:
> [1/3] Add a private data field within kobj_attribute structure.

Your "Subject" did not line up with this description, please change your
patch sending format for the next time.

> This patch add a private data field, declared as void *, within kobj_attribute
> structure. The _show() and _store() method in the sysfs attribute entries can
> refer this information to identify what entry is accessed.
> It makes easier to share a single method implementation with several similar
> entries, like ones to export the list of capabilities the running kernel
> supported.
> 
> Signed-off-by: KaiGai Kohei <kaigai@ak.jp.nec.com>

This looks fine, but I'll not take it unless the documentation is
updated, as well as the sample code.

thanks,

greg k-h

      reply	other threads:[~2008-02-22 17:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-22  1:49 Kohei KaiGai
2008-02-22 17:04 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080222170459.GB18524@kroah.com \
    --to=greg@kroah.com \
    --cc=kaigai@ak.jp.nec.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=morgan@kernel.org \
    --cc=serue@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®