From: "Serge E. Hallyn" <serue@us.ibm.com>
To: Adrian Bunk <bunk@kernel.org>
Cc: "Serge E. Hallyn" <serue@us.ibm.com>, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] kernel/ns_cgroup.c should #include <linux/nsproxy.h>
Date: Fri, 22 Feb 2008 18:02:06 -0600 [thread overview]
Message-ID: <20080223000206.GA14216@sergelap.austin.ibm.com> (raw)
In-Reply-To: <20080222195826.GG1409@cs181133002.pp.htv.fi>
Quoting Adrian Bunk (bunk@kernel.org):
> Every file should include the headers containing the externs its global
> functions (in this case for ns_cgroup_clone()).
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
Seems fine... and a good way to ensure that the prototype and
definition match.
Acked-by: Serge Hallyn <serue@us.ibm.com>
thanks,
-serge
>
> ---
> d3446a02068091d59425c51bde1daea777398e44 diff --git a/kernel/ns_cgroup.c b/kernel/ns_cgroup.c
> index aead4d6..659f321 100644
> --- a/kernel/ns_cgroup.c
> +++ b/kernel/ns_cgroup.c
> @@ -7,6 +7,7 @@
> #include <linux/module.h>
> #include <linux/cgroup.h>
> #include <linux/fs.h>
> +#include <linux/nsproxy.h>
>
> struct ns_cgroup {
> struct cgroup_subsys_state css;
prev parent reply other threads:[~2008-02-23 0:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-22 19:58 Adrian Bunk
2008-02-23 0:02 ` Serge E. Hallyn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080223000206.GA14216@sergelap.austin.ibm.com \
--to=serue@us.ibm.com \
--cc=bunk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®