From: Ingo Molnar <mingo@elte.hu>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Vegard Nossum <vegard.nossum@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: don't save unreliable stack trace entries
Date: Sat, 23 Feb 2008 11:25:39 +0100 [thread overview]
Message-ID: <20080223102539.GK23833@elte.hu> (raw)
In-Reply-To: <20080222104828.3006cd1d@laptopd505.fenrus.org>
* Arjan van de Ven <arjan@infradead.org> wrote:
> > b/arch/x86/kernel/stacktrace.c index 02f0f61..c28c342 100644
> > --- a/arch/x86/kernel/stacktrace.c
> > +++ b/arch/x86/kernel/stacktrace.c
> > @@ -25,6 +25,8 @@ static int save_stack_stack(void *data, char *name)
> > static void save_stack_address(void *data, unsigned long addr, int
> > reliable) {
> > struct stack_trace *trace = data;
> > + if (!reliable)
> > + return;
> > if (trace->skip > 0) {
> > trace->skip--;
> > return;
> > @@ -37,6 +39,8 @@ static void
> > save_stack_address_nosched(void *data, unsigned long addr, int
> > reliable) {
> > struct stack_trace *trace = (struct stack_trace *)data;
> > + if (!reliable)
> > + return;
> > if (in_sched_functions(addr))
> > return;
> > if (trace->skip > 0) {
>
>
> I was about to make a patch for this second chunk myself and submit
> it, so for the second chunk a strong:
> Acked-by: Arjan van de Ven <arjan@linux.intel.com>
how about the first chunk?
Ingo
prev parent reply other threads:[~2008-02-23 10:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-22 18:44 Vegard Nossum
2008-02-22 18:48 ` Arjan van de Ven
2008-02-23 10:25 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080223102539.GK23833@elte.hu \
--to=mingo@elte.hu \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vegard.nossum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®