From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Liam Girdwood <lg@opensource.wolfsonmicro.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.arm.linux.org.uk>
Subject: Re: [PATCH 4/6] regulator: regulator core.
Date: Sun, 24 Feb 2008 10:23:49 +0000 [thread overview]
Message-ID: <20080224102348.GA11156@sirena.org.uk> (raw)
In-Reply-To: <20080223095217.GA28356@flint.arm.linux.org.uk>
On Sat, Feb 23, 2008 at 09:52:17AM +0000, Russell King - ARM Linux wrote:
> On Sat, Feb 23, 2008 at 12:05:38AM -0800, Andrew Morton wrote:
> > > +#undef current
> > err, no ;) Please rename your stuff.
> Renaming is not an option - "current" is an electronic term for which
> there is no alternative. The real problem is this __ATTR macro crap:
Indeed, and this is already being worked around by
drivers/power/power_supply_sysfs.c:
#define POWER_SUPPLY_ATTR(_name) \
{ \
.attr = { .name = #_name, .mode = 0444, .owner = THIS_MODULE }, \
.show = power_supply_show_property, \
.store = NULL, \
}
next prev parent reply other threads:[~2008-02-24 10:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-20 17:09 Liam Girdwood
2008-02-23 8:05 ` Andrew Morton
2008-02-23 9:52 ` Russell King - ARM Linux
2008-02-23 18:18 ` Andrew Morton
2008-02-23 19:26 ` ian
2008-02-23 19:38 ` Andrew Morton
2008-02-24 8:51 ` Pavel Machek
2008-02-24 22:47 ` ian
2008-02-24 10:23 ` Mark Brown [this message]
2008-02-24 11:18 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080224102348.GA11156@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=akpm@linux-foundation.org \
--cc=lg@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®