mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Pekka Paalanen <pq@iki.fi>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
	Christoph Hellwig <hch@infradead.org>,
	Arjan van de Ven <arjan@infradead.org>,
	Pavel Roskin <proski@gnu.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [RFC] mmiotrace full patch, preview 1
Date: Sun, 24 Feb 2008 18:59:55 +0100	[thread overview]
Message-ID: <20080224175955.GB10712@uranus.ravnborg.org> (raw)
In-Reply-To: <20080224190323.77adf683@daedalus.pq.iki.fi>

Hi Pekka.

A small nitpick..
>  
> +config MMIOTRACE_HOOKS
> +	bool
> +	default n
n is default so no need to be explicit.
If you prefer being explcit then use:

	def_bool n

> +config MMIOTRACE
> +	tristate "Memory mapped IO tracing"
> +	depends on DEBUG_KERNEL && RELAY && DEBUG_FS
> +	select MMIOTRACE_HOOKS
> +	default n
Same here.


> +	help
> +	  This will build a kernel module called mmiotrace.
> +	  Making this a built-in is heavily discouraged.
> +
> +	  Mmiotrace traces Memory Mapped I/O access and is meant for debugging
> +	  and reverse engineering. The kernel module offers wrapped
> +	  versions of the ioremap family of functions. The driver to be traced
> +	  must be modified to call these wrappers. A user space program is
> +	  required to collect the MMIO data.
> +
> +	  See http://nouveau.freedesktop.org/wiki/MmioTrace
> +	  If you are not helping to develop drivers, say N.
> +
> +config MMIOTRACE_TEST
> +	tristate "Test module for mmiotrace"
> +	depends on MMIOTRACE && m
> +	default n
> +	help
> +	  This is a dumb module for testing mmiotrace. It is very dangerous
> +	  as it will write garbage to IO memory starting at a given address.
> +	  However, it should be safe to use on e.g. unused portion of VRAM.
> +
> +	  Say N, unless you absolutely know what you are doing.
> +
>  #
>  # IO delay types:
>  #
> diff --git a/arch/x86/mm/Makefile b/arch/x86/mm/Makefile
> index 9832910..e182f6d 100644
> --- a/arch/x86/mm/Makefile
> +++ b/arch/x86/mm/Makefile
> @@ -3,3 +3,8 @@ include ${srctree}/arch/x86/mm/Makefile_32
>  else
>  include ${srctree}/arch/x86/mm/Makefile_64
>  endif
> +
> +obj-$(CONFIG_MMIOTRACE_HOOKS)	+= kmmio.o
> +obj-$(CONFIG_MMIOTRACE) 	+= mmiotrace.o
> +mmiotrace-objs			:= pf_in.o mmio-mod.o

Do not use '-objs' - '-y' is preferred as below:
> +mmiotrace-y				:= pf_in.o mmio-mod.o


	Sam

  reply	other threads:[~2008-02-24 17:59 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-24 17:03 Pekka Paalanen
2008-02-24 17:59 ` Sam Ravnborg [this message]
2008-02-25 22:49 ` Andrew Morton
2008-02-25 23:34   ` Christoph Hellwig
2008-02-26  2:42     ` Pavel Roskin
2008-02-26  8:57       ` Andy Whitcroft
2008-02-26 17:10       ` Christoph Hellwig
2008-02-26 10:21     ` Andy Whitcroft
2008-02-26 10:49       ` Ingo Molnar
2008-02-26 15:20         ` Andy Whitcroft
2008-02-26 20:02   ` Pekka Paalanen
2008-02-26 17:20 ` Jonathan Corbet
2008-02-27 20:28   ` Pekka Paalanen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080224175955.GB10712@uranus.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=arjan@infradead.org \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=pq@iki.fi \
    --cc=proski@gnu.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®