From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Zdenek Kabelac <zdenek.kabelac@gmail.com>
Cc: linux-kernel@vger.kernel.org, len.brown@intel.com
Subject: Re: latest commit on thinkpad_acpi.c 6c231bd5eb07 shows warning
Date: Mon, 25 Feb 2008 15:27:43 -0300 [thread overview]
Message-ID: <20080225182743.GA16513@khazad-dum.debian.net> (raw)
In-Reply-To: <c4e36d110802241407q4808e3f8n318723a70696fd0d@mail.gmail.com>
On Sun, 24 Feb 2008, Zdenek Kabelac wrote:
> Commit 6c231bd5eb07ce546517019f334652b9ecfc329a
> generate this warning:
>
> drivers/misc/thinkpad_acpi.c: In function 'tpacpi_input_send_tabletsw':
> include/linux/input.h:1290: warning: 'state' is used uninitialized in
> this function
> drivers/misc/thinkpad_acpi.c:1191: note: 'state' was declared here
> drivers/misc/thinkpad_acpi.c: In function 'hotkey_tablet_mode_show':
> drivers/misc/thinkpad_acpi.c:1723: warning: 's' is used uninitialized
> in this function
>
> I assume typo here thinkpad_acpi.c:10724 hotkey_get_tablet_mode
> where status should be maybe 's' and local 's' shouldn't be defined at
> all - just guess?
Erk. Looks like I tested one branch and did a git-send-email on the other
or something equally pathetic. Sorry about that.
I will check the entire thing over line by line and send a fix.
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
next prev parent reply other threads:[~2008-02-25 18:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-24 22:07 Zdenek Kabelac
2008-02-25 18:27 ` Henrique de Moraes Holschuh [this message]
2008-02-25 19:01 ` Henrique de Moraes Holschuh
2008-02-25 19:11 ` Zdenek Kabelac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080225182743.GA16513@khazad-dum.debian.net \
--to=hmh@hmh.eng.br \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=zdenek.kabelac@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®