From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754732AbYB1FxK (ORCPT ); Thu, 28 Feb 2008 00:53:10 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751486AbYB1Fw5 (ORCPT ); Thu, 28 Feb 2008 00:52:57 -0500 Received: from ug-out-1314.google.com ([66.249.92.171]:33795 "EHLO ug-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751240AbYB1Fw4 (ORCPT ); Thu, 28 Feb 2008 00:52:56 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=date:to:cc:subject:message-id:reply-to:mail-followup-to:references:mime-version:content-type:content-disposition:content-transfer-encoding:in-reply-to:user-agent:from; b=ccmvPVpAly3RD1mr9wnzFw1YJ7fivIzrwfswRnjgzy9D7kehGG7NxNgCHO6ZaK1MbbZs1cEv2Eju4JYE2RYP6x7OwNe9sleHSseDoTAgCjflQxyb6brr+ijlFF4qVAkU6b1H1DrzlYHcA/0NSZr+k3koMLr1I2CBlGyJszDw/qQ= Date: Thu, 28 Feb 2008 06:52:51 +0100 To: Bartlomiej Zolnierkiewicz Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org Subject: Re: [PATCH 0/5] ide-cd: trivial fixes Message-ID: <20080228055251.GD9545@gollum.tnic> Reply-To: petkovbb@gmail.com Mail-Followup-To: petkovbb@gmail.com, Bartlomiej Zolnierkiewicz , linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org References: <1204136449-9490-1-git-send-email-petkovbb@gmail.com> <200802272218.40312.bzolnier@gmail.com> <20080227221814.GC9545@gollum.tnic> <200802272348.35011.bzolnier@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <200802272348.35011.bzolnier@gmail.com> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) From: Borislav Petkov Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 27, 2008 at 11:48:34PM +0100, Bartlomiej Zolnierkiewicz wrote: > On Wednesday 27 February 2008, Borislav Petkov wrote: > > On Wed, Feb 27, 2008 at 10:18:40PM +0100, Bartlomiej Zolnierkiewicz wrote: > > > > > > Hi, > > > > > > On Wednesday 27 February 2008, Borislav Petkov wrote: > > > > Hi Bart, > > > > > > > > here are the ide-cd trivial fixes split in an easier to digest format. I > > > > cannot do the md5sum check here since all of the patches change at least one > > > > char but i hope that this'll be redundant here since they're trivially easy > > > > to review :) now. > > > > > > > > drivers/ide/ide-cd.c | 591 +++++++++++++++++++++++++------------------------- > > > > 1 files changed, 298 insertions(+), 293 deletions(-) > > > > > > applied everything > > > > > > BTW patch #3/5 which accounts for 2/3 of the diffstat passes md5sum check here > > > > huh, are you sure? The fixup-comments patch adds at least one char to the source > > file so the md5sums cannot be the same. > > OTOH md5sums of the resulting _binary_ files matches... ;-) right, the compiler discards all comments during compilation and the sole code remains unchanged. -- Regards/Gruß, Boris.