From: Andrey Panin <pazke@pazke.donpac.ru>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/visws: fix printk format warnings
Date: Fri, 29 Feb 2008 19:52:17 +0300 [thread overview]
Message-ID: <20080229165217.GB6575@pazke.donpac.ru> (raw)
In-Reply-To: <20080211100509.325eb561.randy.dunlap@oracle.com>
[-- Attachment #1: Type: text/plain, Size: 1443 bytes --]
On 042, 02 11, 2008 at 10:05:09AM -0800, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Fix visws printk format warnings:
>
> /local/linsrc/linux-2.6.24-git15/arch/x86/mach-visws/traps.c:50: warning: format '%#lx' expects type 'long unsigned int', but argument 2 has type 'u32'
> /local/linsrc/linux-2.6.24-git15/arch/x86/mach-visws/traps.c:50: warning: format '%#lx' expects type 'long unsigned int', but argument 3 has type 'u32'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
> arch/x86/mach-visws/traps.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> --- linux-2.6.24-git15.orig/arch/x86/mach-visws/traps.c
> +++ linux-2.6.24-git15/arch/x86/mach-visws/traps.c
> @@ -46,8 +46,9 @@ static __init void cobalt_init(void)
> */
> set_fixmap(FIX_APIC_BASE, APIC_DEFAULT_PHYS_BASE);
> setup_local_APIC();
> - printk(KERN_INFO "Local APIC Version %#lx, ID %#lx\n",
> - apic_read(APIC_LVR), apic_read(APIC_ID));
> + printk(KERN_INFO "Local APIC Version %#x, ID %#x\n",
> + (unsigned int)apic_read(APIC_LVR),
> + (unsigned int)apic_read(APIC_ID));
>
> set_fixmap(FIX_CO_CPU, CO_CPU_PHYS);
> set_fixmap(FIX_CO_APIC, CO_APIC_PHYS);
Sorry for so late answer, I missed your mail somehow :(
Acked-By: Andrey Panin <pazke@donpac.ru>
--
Andrey Panin | Linux and UNIX system administrator
pazke@donpac.ru | PGP key: wwwkeys.pgp.net
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
prev parent reply other threads:[~2008-02-29 18:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-11 18:05 Randy Dunlap
2008-02-29 16:52 ` Andrey Panin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080229165217.GB6575@pazke.donpac.ru \
--to=pazke@pazke.donpac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®