From: David Miller <davem@davemloft.net>
To: hannemann@nets.rwth-aachen.de
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Removing unneeded statement from tcp_ipv4.c
Date: Mon, 03 Mar 2008 10:51:05 -0800 (PST) [thread overview]
Message-ID: <20080303.105105.189914871.davem@davemloft.net> (raw)
In-Reply-To: <47CBFBDA.7000801@nets.rwth-aachen.de>
From: Arnd Hannemann <hannemann@nets.rwth-aachen.de>
Date: Mon, 03 Mar 2008 14:23:38 +0100
> - if (tmp_opt.saw_tstamp && !tmp_opt.rcv_tsval) {
> + if (tmp_opt.saw_tstamp && !tmp_opt.rcv_tsval)
> /* Some OSes (unknown ones, but I see them on web server, which
> * contains information interesting only for windows'
> * users) do not send their stamp in SYN. It is easy case.
> * We simply do not advertise TS support.
> */
> tmp_opt.saw_tstamp = 0;
> - tmp_opt.tstamp_ok = 0;
> - }
> +
Please don't format it like this.
When there is a multi-line comment, you should still enclose
the basic block in braces. It's unreadable otherwise.
prev parent reply other threads:[~2008-03-03 18:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-03 13:23 Arnd Hannemann
2008-03-03 14:08 ` Ilpo Järvinen
2008-03-03 23:18 ` [PATCH-RESEND] " Arnd Hannemann
2008-03-06 3:00 ` David Miller
2008-03-06 10:46 ` Arnd Hannemann
2008-03-03 18:51 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080303.105105.189914871.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hannemann@nets.rwth-aachen.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®