From: Christoph Hellwig <hch@lst.de>
To: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Cc: Jens Axboe <axboe@kernel.dk>,
Linux Kernel Development <linux-kernel@vger.kernel.org>,
Cell Broadband Engine OSS Development <cbe-oss-dev@ozlabs.org>
Subject: Re: [Cbe-oss-dev] [PATCH] ps3disk: Remove a superfluous cast
Date: Mon, 3 Mar 2008 05:19:16 +0100 [thread overview]
Message-ID: <20080303041916.GB22960@lst.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0802151440090.21784@vixen.sonytel.be>
On Fri, Feb 15, 2008 at 02:42:03PM +0100, Geert Uytterhoeven wrote:
> ps3disk: Remove a superfluous cast
>
> As ps3disk is a ppc64-only driver, sector_t equals to unsigned long, and the
> cast is not needed.
>
> Reuse in another (possibly 32-bit) driver is protected by the safety net called
> `compiler warning' (with the cast, it may silently truncate to 32-bit).
> If sector_t ever changes, we will get a compiler warning as well (with the
> cast, we won't).
Yes, this sounds fine to me.
ACK.
prev parent reply other threads:[~2008-03-03 4:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-15 13:42 Geert Uytterhoeven
2008-03-03 4:19 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080303041916.GB22960@lst.de \
--to=hch@lst.de \
--cc=Geert.Uytterhoeven@sonycom.com \
--cc=axboe@kernel.dk \
--cc=cbe-oss-dev@ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®