From: David Brownell <david-b@pacbell.net>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Christian Kujau <lists@nerdbynature.de>,
LKML <linux-kernel@vger.kernel.org>,
0x0007@gmail.com, USB list <linux-usb@vger.kernel.org>
Subject: Re: WARNING: at drivers/usb/host/ehci-hcd.c:287
Date: Tue, 4 Mar 2008 14:01:41 -0800 [thread overview]
Message-ID: <200803041401.41880.david-b@pacbell.net> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0803041553320.15986-100000@iolanthe.rowland.org>
On Tuesday 04 March 2008, Alan Stern wrote:
> > > How about replacing the
> > >
> > > WARN_ON(!ehci->reclaim);
> >
> > Or bettter yet, just removing it entirely. ISTR doing that in some
> > patches I've not yet sent for merging, and expect that's what my
> > preferred fix will be ...
>
> But removing the WARN_ON won't fix the problem.
It fully resolves the $SUBJECT problem. :)
> The routine still
> needs to exit immediately if ehci->reclaim isn't set,
It more or less does that already; it does some avoidable
work, but that's not incorrect.
> the root hub isn't running, or the timer has been restarted.
Those are different issues.
- Dave
next prev parent reply other threads:[~2008-03-04 22:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-03 0:05 Christian Kujau
2008-03-03 22:38 ` Christian Kujau
2008-03-04 16:29 ` Alan Stern
2008-03-04 18:53 ` Christian Kujau
2008-03-04 20:27 ` Alan Stern
2008-03-04 20:51 ` David Brownell
2008-03-04 20:57 ` Alan Stern
2008-03-04 22:01 ` David Brownell [this message]
2008-03-04 23:15 ` Christian Kujau
2008-03-05 0:30 ` David Brownell
2008-03-05 1:15 ` Christian Kujau
2008-03-05 4:25 ` David Brownell
2008-03-05 22:59 ` Christian Kujau
2008-03-07 19:51 ` Christian Kujau
2008-03-04 7:49 ` Andrew Morton
2008-03-04 8:01 ` Christian Kujau
2008-03-04 8:10 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200803041401.41880.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=0x0007@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lists@nerdbynature.de \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome