From: Adrian Bunk <bunk@kernel.org>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/9] scsi: replace __inline with inline
Date: Wed, 5 Mar 2008 15:32:09 +0200 [thread overview]
Message-ID: <20080305133209.GA24165@cs181133002.pp.htv.fi> (raw)
In-Reply-To: <1204679836.5698.67.camel@brick>
On Tue, Mar 04, 2008 at 05:17:16PM -0800, Harvey Harrison wrote:
>...
> --- a/drivers/scsi/aic7xxx/aic79xx_core.c
> +++ b/drivers/scsi/aic7xxx/aic79xx_core.c
> @@ -268,7 +268,7 @@ static int ahd_match_scb(struct ahd_softc *ahd, struct scb *scb,
>
> /******************************** Private Inlines *****************************/
>
> -static __inline void
> +static inline void
> ahd_assert_atn(struct ahd_softc *ahd)
> {
> ahd_outb(ahd, SCSISIGO, ATNO);
>...
inline's in .c files in the kernel are in 99,9% of all cases the wrong
thing, so when you anyway touch this code you cold as well remove them.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
prev parent reply other threads:[~2008-03-05 13:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-05 1:17 Harvey Harrison
2008-03-05 13:32 ` Adrian Bunk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080305133209.GA24165@cs181133002.pp.htv.fi \
--to=bunk@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=akpm@linux-foundation.org \
--cc=harvey.harrison@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®