mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Whitcroft <apw@shadowen.org>
To: Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: Make some text more consinstent and informative
Date: Thu, 6 Mar 2008 10:20:26 +0000	[thread overview]
Message-ID: <20080306102026.GB25123@shadowen.org> (raw)
In-Reply-To: <47CF0748.3060203@gmail.com>

On Wed, Mar 05, 2008 at 09:49:12PM +0100, Paolo Ciarrocchi wrote:
> Hi Andy,
> 
> Now messages about missing spaces or not needed spaces are in the format:
> 	space is required
> 	space is not required
> 
> Signed-off-by: Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com>

The current version (which your patch has crossed with) has these changed
to "required" and "prohibited" respectivly, to remove the ambiguity introduced by
tehe "no spaces X" form.

I did consider and reject the "is not required" form.  In english this
does not correct carry the "must not be present" meaning, it more means
"may or may not be present at your option".  Which is not what we are
trying to say either.

Hopefully the new wording is clearer to native and non-native english
speakers alike.

Thanks for doing the patch even so.

-apw

  reply	other threads:[~2008-03-06 10:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-05 20:49 Paolo Ciarrocchi
2008-03-06 10:20 ` Andy Whitcroft [this message]
2008-03-06 22:33   ` Paolo Ciarrocchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080306102026.GB25123@shadowen.org \
    --to=apw@shadowen.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paolo.ciarrocchi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®