From: Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com>
To: hpa <hpa@zytor.com>, Ingo Molnar <mingo@elte.hu>,
tglx <tglx@linutronix.de>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH 2/2] x86: coding style fixes to arch/x86/kernel/setup_32.c
Date: Fri, 7 Mar 2008 19:26:26 +0100 [thread overview]
Message-ID: <20080307192626.4673455b@paolo-desktop> (raw)
Fix one:
ERROR: do not initialise externals to 0 or NULL
The change affects the generated binary file:
paolo@paolo-desktop:/tmp/a$ size setup_32.o*
text data bss dec hex filename
3526 7406 885 11817 2e29 setup_32.o
3526 7406 885 11817 2e29 setup_32.o.after
3526 7410 885 11821 2e2d setup_32.o.after.initialise
paolo@paolo-desktop:/tmp/a$ md5sum setup_32.o*
d238f977facb3b4e4ee6a18390678376 setup_32.o
d238f977facb3b4e4ee6a18390678376 setup_32.o.after
1c43448c2f50d22215857741ffe5eca5 setup_32.o.after.initialise
Signed-off-by: Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com>
---
arch/x86/kernel/setup_32.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/setup_32.c b/arch/x86/kernel/setup_32.c
index b120a1c..029354b 100644
--- a/arch/x86/kernel/setup_32.c
+++ b/arch/x86/kernel/setup_32.c
@@ -228,7 +228,7 @@ static inline void copy_edd(void)
}
#endif
-int __initdata user_defined_memmap = 0;
+int __initdata user_defined_memmap;
/*
* "mem=nopentium" disables the 4MB page tables.
--
1.5.4.2.316.gf7a7
reply other threads:[~2008-03-07 18:28 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080307192626.4673455b@paolo-desktop \
--to=paolo.ciarrocchi@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®