From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933170AbYCGVYx (ORCPT ); Fri, 7 Mar 2008 16:24:53 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932356AbYCGVYl (ORCPT ); Fri, 7 Mar 2008 16:24:41 -0500 Received: from sca-es-mail-2.Sun.COM ([192.18.43.133]:58309 "EHLO sca-es-mail-2.sun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932257AbYCGVYk (ORCPT ); Fri, 7 Mar 2008 16:24:40 -0500 Date: Fri, 07 Mar 2008 14:24:26 -0700 From: Andreas Dilger Subject: Re: [PATCH 3/3] jbd2: only create debugfs and stats entries if cache initialisation is successful In-reply-to: To: Duane Griffin Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, Theodore Tso , sct@redhat.com, akpm@linux-foundation.org, adilger@clusterfs.com Message-id: <20080307212426.GF1881@webber.adilger.int> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7BIT Content-disposition: inline X-GPG-Key: 1024D/0D35BED6 X-GPG-Fingerprint: 7A37 5D79 BF1B CECA D44F 8A29 A488 39F5 0D35 BED6 References: <5e28cd633c71f6354a203a43000cbe5fef045589.1204844851.git.duaneg@dghda.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mar 07, 2008 01:31 +0000, Duane Griffin wrote: > jbd2 debugfs and stats entries should only be created if cache initialisation > is successful. At the moment they are being created unconditionally which will > leave them dangling if cache (and hence module) initialisation fails. > > Signed-off-by: Duane Griffin Acked-by: Andreas Dilger > --- > fs/jbd2/journal.c | 8 +++++--- > 1 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c > index 0d8a595..9d48419 100644 > --- a/fs/jbd2/journal.c > +++ b/fs/jbd2/journal.c > @@ -2315,10 +2315,12 @@ static int __init journal_init(void) > BUILD_BUG_ON(sizeof(struct journal_superblock_s) != 1024); > > ret = journal_init_caches(); > - if (ret != 0) > + if (ret == 0) { > + jbd2_create_debugfs_entry(); > + jbd2_create_jbd_stats_proc_entry(); > + } else { > jbd2_journal_destroy_caches(); > - jbd2_create_debugfs_entry(); > - jbd2_create_jbd_stats_proc_entry(); > + } > return ret; > } > > -- > 1.5.3.7 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc.