From: WANG Cong <xiyou.wangcong@gmail.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>, "G. Vaughan" <gvaughan@jpl.nasa.gov>,
Andrew Morton <akpm@osdl.org>
Subject: [PATCH] Fix check after use in kernel/exit.c
Date: Sat, 08 Mar 2008 16:11:05 +0800 (CST) [thread overview]
Message-ID: <20080308.161105.253167431.xiyou.wangcong@gmail.com> (raw)
mm_release won't check the mm_struct pointer, so it should
be checked before this call.
This patch was first posted here[1], and I don't know
why it was not accepted yet.
Thanks to "G. Vaughan" to remind me about this.
1. http://lkml.org/lkml/2007/11/15/520
Cc: Ingo Molnar <mingo@elte.hu>
Cc: "G. Vaughan" <gvaughan@jpl.nasa.gov>
Signed-off-by: WANG Cong <xiyou.wangcong@gmail.com>
---
kernel/exit.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/exit.c b/kernel/exit.c
index cd20bf0..0cb9cce 100644
--- a/kernel/exit.c
+++ b/kernel/exit.c
@@ -582,9 +582,9 @@ static void exit_mm(struct task_struct * tsk)
{
struct mm_struct *mm = tsk->mm;
- mm_release(tsk, mm);
if (!mm)
return;
+ mm_release(tsk, mm);
/*
* Serialize with any possible pending coredump.
* We must hold mmap_sem around checking core_waiters
--
1.5.2.4
next reply other threads:[~2008-03-08 8:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-08 8:11 WANG Cong [this message]
2008-03-08 8:36 ` Ingo Molnar
2008-03-08 8:53 ` Ingo Molnar
2008-03-08 8:58 ` WANG Cong
2008-03-09 11:48 ` Ingo Molnar
2008-03-10 8:23 ` WANG Cong
2008-03-10 9:13 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080308.161105.253167431.xiyou.wangcong@gmail.com \
--to=xiyou.wangcong@gmail.com \
--cc=akpm@osdl.org \
--cc=gvaughan@jpl.nasa.gov \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®