From: Rik van Riel <riel@redhat.com>
To: Davide Libenzi <davidel@xmailserver.org>
Cc: Jeff Roberson <jroberson@chesapeake.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Zach Brown <zach.brown@oracle.com>
Subject: Re: [PATCH] eventfd signal race in aio_complete()
Date: Sat, 8 Mar 2008 10:23:21 -0500 [thread overview]
Message-ID: <20080308102321.4527372e@bree.surriel.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0803071955490.13626@alien.or.mcafeemobile.com>
On Fri, 7 Mar 2008 20:29:20 -0800 (PST)
Davide Libenzi <davidel@xmailserver.org> wrote:
> The second solution/patch simply moves the eventfd_signal() call before
> the __aio_put_req() call, but after the event has beed "ringed".
> We should be clear to go with the shorter/nicer second solution. Those
> patches builds, but I'm not even signing them off till I tested them.
If there are no spinlock ordering issues between &ctx->ctx_lock
and &ctx->wqh.lock (taken inside eventfd_signal), then the second
patch is indeed preferable.
Jeff and I did look at that briefly last night, but were not
familiar enough with the code to decide whether or not that was
safe.
--
All rights reversed.
next prev parent reply other threads:[~2008-03-08 15:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-08 2:32 Jeff Roberson
2008-03-08 4:29 ` Davide Libenzi
2008-03-08 15:23 ` Rik van Riel [this message]
2008-03-08 20:38 ` Davide Libenzi
2008-03-08 21:38 ` Jeff Roberson
2008-03-08 21:55 ` Davide Libenzi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080308102321.4527372e@bree.surriel.com \
--to=riel@redhat.com \
--cc=davidel@xmailserver.org \
--cc=jroberson@chesapeake.net \
--cc=linux-kernel@vger.kernel.org \
--cc=zach.brown@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®