From: "Duane Griffin" <duaneg@dghda.com>
To: Mingming Cao <cmm@us.ibm.com>
Cc: Andreas Dilger <adilger@sun.com>,
Duane Griffin <duaneg@dghda.com>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
Theodore Tso <tytso@mit.edu>,
sct@redhat.com, akpm@linux-foundation.org, adilger@clusterfs.com
Subject: Re: [PATCH 1/3] jbd2: eliminate duplicated code in revocation table init/destroy functions
Date: Sat, 8 Mar 2008 13:26:14 +0000 [thread overview]
Message-ID: <20080308132614.GA9412@dastardly.plus.com> (raw)
In-Reply-To: <1204934726.14884.63.camel@localhost.localdomain>
On Fri, Mar 07, 2008 at 04:05:26PM -0800, Mingming Cao wrote:
> > > + if (!journal->j_revoke_table[0])
> > > + goto failed_alloc1;
> > > + if (jbd2_journal_init_revoke_table(journal->j_revoke_table[0], hash_size))
> >
> > (style) wrap at 80 columns.
> >
>
> checkpatch.pl catched this...fyi.
It did :)
After following recent LKML threads on this I figured it would probably
be more readable to leave it than fix it. I should have mentioned that,
sorry. Anyway, it is no longer an issue after addressing Andreas'
comments.
> Thanks for reviewing this Andreas.
My thanks, too. I really appreciate the quick and thorough review.
> The patch is already in ext4 candidate patch queue. FYI.
If I can do anything to simplify updating it with revised versions then
let me know.
> Mingming
Cheers,
Duane.
--
"I never could learn to drink that blood and call it wine" - Bob Dylan
next prev parent reply other threads:[~2008-03-08 13:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5e28cd633c71f6354a203a43000cbe5fef045589.1204844851.git.duaneg@dghda.com>
2008-03-07 1:31 ` Duane Griffin
[not found] ` <48afbb3a44aa24dc1e31835c14e86c3c6c1c3b0a.1204844851.git.duaneg@dghda.com>
2008-03-07 1:31 ` [PATCH 2/3] jbd2: replace potentially false assertion with if block Duane Griffin
2008-03-07 21:23 ` Andreas Dilger
2008-03-08 13:33 ` Duane Griffin
2008-03-08 15:02 ` Christoph Hellwig
2008-03-08 16:40 ` Duane Griffin
2008-03-08 16:42 ` Christoph Hellwig
2008-03-08 18:37 ` Duane Griffin
2008-03-08 18:45 ` Christoph Hellwig
[not found] ` <dcb02b202f5a84c79c9e8b1b0102e6ad52ed3b53.1204844851.git.duaneg@dghda.com>
2008-03-07 1:31 ` [PATCH 3/3] jbd2: only create debugfs and stats entries if cache initialisation is successful Duane Griffin
2008-03-07 21:24 ` Andreas Dilger
2008-03-07 21:52 ` [PATCH 1/3] jbd2: eliminate duplicated code in revocation table init/destroy functions Andreas Dilger
2008-03-08 0:05 ` Mingming Cao
2008-03-08 13:26 ` Duane Griffin [this message]
2008-03-08 13:20 ` Duane Griffin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080308132614.GA9412@dastardly.plus.com \
--to=duaneg@dghda.com \
--cc=adilger@clusterfs.com \
--cc=adilger@sun.com \
--cc=akpm@linux-foundation.org \
--cc=cmm@us.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sct@redhat.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®