From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753993AbYCJErb (ORCPT ); Mon, 10 Mar 2008 00:47:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750922AbYCJErX (ORCPT ); Mon, 10 Mar 2008 00:47:23 -0400 Received: from mx1.redhat.com ([66.187.233.31]:38631 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750819AbYCJErW (ORCPT ); Mon, 10 Mar 2008 00:47:22 -0400 From: Jarod Wilson Organization: Red Hat, Inc. To: linux1394-devel@lists.sourceforge.net Subject: Re: [PATCH] firewire: debug AT, AR, and selfID-complete events Date: Mon, 10 Mar 2008 00:47:05 -0400 User-Agent: KMail/1.9.9 Cc: Stefan Richter , linux-kernel@vger.kernel.org References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200803100047.05387.jwilson@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday 09 March 2008 04:49:34 pm Stefan Richter wrote: > This adds debug printks for asynchronous transmission and reception and > for self ID reception. The debug code is per default deactivated by #if > blocks. > > Signed-off-by: Stefan Richter > --- > > I am undecided whether this is OK for mainline, and whether the debug > options should become a Kconfig option or runtime options. > > It may be temporarily useful to the few driver developers. Do we want > end users to provide us with debug logs of this kind? Then it should > be one or two runtime options. My vote would be to include this sort of thing with a run-time option to enable the extra spew, since its a perfectly accepted standard for other drivers. It ought to be extremely useful in determining whats going wrong with end-user setups, particularly in cases where we can't reproduce the problem (typically for lack of having the specific hardware in-house). -- Jarod Wilson jwilson@redhat.com