mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: Roel Kluin <12o3l@tiscali.nl>
Cc: Joe Perches <joe@perches.com>,
	v4l-dvb-maintainer@linuxtv.org, video4linux-list@redhat.com,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] em28xx-core.c: add missing parentheses in em28xx_write_ac97()
Date: Mon, 10 Mar 2008 09:23:57 -0300	[thread overview]
Message-ID: <20080310092357.61020c7e@gaivota> (raw)
In-Reply-To: <47CEE9E2.6040303@tiscali.nl>

Roel and Joe,

Thanks for your patches.

I've already received and committed two patches with your proposed changes:

http://linuxtv.org/hg/v4l-dvb/rev/127f67dea087
http://linuxtv.org/hg/v4l-dvb/rev/f83ed13f5bf5

Cheers,
Mauro

On Wed, 05 Mar 2008 19:43:46 +0100
Roel Kluin <12o3l@tiscali.nl> wrote:

> Joe Perches wrote:
> 
> >> -		if (!((u8) ret) & 0x01)
> >> +		if (!(((u8) ret) & 0x01))
> > 
> > I think it'd be clearer without the cast to (u8)
> > which is then implicit cast back to int anyway
> > 
> > 	if (!(ret & 1))
> 
> ok.
> ---
> 
> Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
> ---
> diff --git a/drivers/media/video/em28xx/em28xx-core.c b/drivers/media/video/em28xx/em28xx-core.c
> index 7d1537c..c797472 100644
> --- a/drivers/media/video/em28xx/em28xx-core.c
> +++ b/drivers/media/video/em28xx/em28xx-core.c
> @@ -267,7 +267,7 @@ static int em28xx_write_ac97(struct em28xx *dev, u8 reg, u8 *val)
>  	for (i = 0; i < 10; i++) {
>  		if ((ret = em28xx_read_reg(dev, AC97BUSY_REG)) < 0)
>  			return ret;
> -		if (!((u8) ret) & 0x01)
> +		if (!(ret & 1))
>  			return 0;
>  		msleep(5);
>  	}




Cheers,
Mauro

      reply	other threads:[~2008-03-10 12:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-05 17:55 Roel Kluin
2008-03-05 18:16 ` Joe Perches
2008-03-05 18:43   ` Roel Kluin
2008-03-10 12:23     ` Mauro Carvalho Chehab [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080310092357.61020c7e@gaivota \
    --to=mchehab@infradead.org \
    --cc=12o3l@tiscali.nl \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=v4l-dvb-maintainer@linuxtv.org \
    --cc=video4linux-list@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®