From: Pierre Ossman <drzeus-mmc@drzeus.cx>
To: Roel Kluin <12o3l@tiscali.nl>, Alex Dubov <oakad@yahoo.com>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: MMC: logical-bitwise and confusion in tifm_sd_transfer_data()?
Date: Mon, 10 Mar 2008 13:56:30 +0100 [thread overview]
Message-ID: <20080310135630.5184b87b@mjolnir.drzeus.cx> (raw)
In-Reply-To: <47D4490C.7030204@tiscali.nl>
On Sun, 09 Mar 2008 21:31:08 +0100
Roel Kluin <12o3l@tiscali.nl> wrote:
> from drivers/mmc/host/tifm_sd.c:183:
>
> if ((r_data->flags & MMC_DATA_WRITE)
> && DATA_CARRY)
>
> shouldn't this be bit-wise &?
First off, I'm not the maintainer of that driver, Alex Dubov is.
Second, the code seems broken, but not in the way you suggest. It should probably have been:
if ((r_data->flags & MMC_DATA_WRITE)
&& (host->cmd_flags & DATA_CARRY))
Alex, could you have a look?
Rgds
--
-- Pierre Ossman
Linux kernel, MMC maintainer http://www.kernel.org
PulseAudio, core developer http://pulseaudio.org
rdesktop, core developer http://www.rdesktop.org
next prev parent reply other threads:[~2008-03-10 12:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-09 20:31 Roel Kluin
2008-03-10 12:56 ` Pierre Ossman [this message]
2008-03-11 7:40 ` Alex Dubov
2008-03-11 8:00 ` [PATCH] MMC: DATA_CARRY is not boolean in tifm_sd_transfer_data() (was: MMC: logical-bitwise and confusion in tifm_sd_transfer_data()?) Roel Kluin
2008-03-15 15:01 ` Pierre Ossman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080310135630.5184b87b@mjolnir.drzeus.cx \
--to=drzeus-mmc@drzeus.cx \
--cc=12o3l@tiscali.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=oakad@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®