From: "Darrick J. Wong" <djwong@us.ibm.com>
To: Roel Kluin <12o3l@tiscali.nl>
Cc: Segher Boessenkool <segher@kernel.crashing.org>,
benh@kernel.crashing.org, linuxppc-dev@ozlabs.org,
lkml <linux-kernel@vger.kernel.org>,
Colin Leroy <colin@colino.net>
Subject: Re: ADT746X: logical-bitwise & confusion in set_max_duty_at_crit()
Date: Mon, 10 Mar 2008 11:13:19 -0700 [thread overview]
Message-ID: <20080310181319.GA7500@tree.beaverton.ibm.com> (raw)
In-Reply-To: <47D5068F.8050709@tiscali.nl>
On Mon, Mar 10, 2008 at 10:59:43AM +0100, Roel Kluin wrote:
> > The & 0xff here is bogus anyway; temp is only ever used as an u8,
> > so just declare it as that, or do proper overflow/underflow checking
> > on it. The patch will need testing on hardware too, since it changes
> > behaviour (it should be a bugfix, but who knows).
>
> Maybe someone can test this?
I did. No regressions observed and it fixes that bug as well. Sorry I
didn't catch it earlier... :/
Acked-by: Darrick J. Wong <djwong@us.ibm.com>
--D
next prev parent reply other threads:[~2008-03-10 18:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-10 0:04 Roel Kluin
2008-03-10 7:46 ` Colin Leroy
2008-03-10 8:06 ` Benjamin Herrenschmidt
2008-03-10 8:22 ` Roel Kluin
2008-03-10 9:13 ` Segher Boessenkool
2008-03-10 9:59 ` Roel Kluin
2008-03-10 18:13 ` Darrick J. Wong [this message]
2008-03-10 21:17 ` Roel Kluin
2008-03-10 21:56 ` Segher Boessenkool
2008-03-10 22:15 ` Roel Kluin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080310181319.GA7500@tree.beaverton.ibm.com \
--to=djwong@us.ibm.com \
--cc=12o3l@tiscali.nl \
--cc=benh@kernel.crashing.org \
--cc=colin@colino.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®