From: Roland McGrath <roland@redhat.com>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>, Pavel Emelyanov <xemul@openvz.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] signals: fold sig_ignored() into handle_stop_signal()
Date: Wed, 12 Mar 2008 14:58:48 -0700 (PDT) [thread overview]
Message-ID: <20080312215848.606F726F992@magilla.localdomain> (raw)
In-Reply-To: Oleg Nesterov's message of Wednesday, 12 March 2008 15:33:11 +0300 <20080312123311.GA13478@tv-sign.ru>
This one looks fine to me. I would like the comment above the function to
be updated to describe its new purpose, and to document its return value's
meaning.
Also, I'm not sure if there is a kernel code formatting convention that
particularly excludes an empty block ({}, equiv to ;) containing just
comments. But I don't recall seeing that style used in the kernel.
(I don't mind it personally for this case given what the obvious
alternatives would look like.)
Thanks,
Roland
next prev parent reply other threads:[~2008-03-12 21:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-12 12:33 Oleg Nesterov
2008-03-12 21:58 ` Roland McGrath [this message]
2008-03-12 22:28 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080312215848.606F726F992@magilla.localdomain \
--to=roland@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@tv-sign.ru \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®