From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755819AbYCMMGH (ORCPT ); Thu, 13 Mar 2008 08:06:07 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753188AbYCMMFy (ORCPT ); Thu, 13 Mar 2008 08:05:54 -0400 Received: from styx.suse.cz ([82.119.242.94]:36286 "EHLO duck.suse.cz" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753100AbYCMMFx (ORCPT ); Thu, 13 Mar 2008 08:05:53 -0400 Date: Thu, 13 Mar 2008 13:05:52 +0100 From: Jan Kara To: Andrew Morton Cc: linux-kernel@vger.kernel.org Subject: [PATCH 1/3] Add possibly missing iput() when quotaon and quotaoff races Message-ID: <20080313120552.GC12523@duck.suse.cz> References: <20080313120344.GB12523@duck.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080313120344.GB12523@duck.suse.cz> User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We should always put inode we have reference to, even if quota was reenabled in the mean time. Signed-off-by: Jan Kara --- dquot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/dquot.c b/fs/dquot.c index f816d06..24eef58 100644 --- a/fs/dquot.c +++ b/fs/dquot.c @@ -1522,8 +1522,8 @@ int vfs_quota_off(struct super_block *sb, int type) truncate_inode_pages(&toputinode[cnt]->i_data, 0); mutex_unlock(&toputinode[cnt]->i_mutex); mark_inode_dirty(toputinode[cnt]); - iput(toputinode[cnt]); } + iput(toputinode[cnt]); mutex_unlock(&dqopt->dqonoff_mutex); } if (sb->s_bdev)