From: Andrew Morton <akpm@linux-foundation.org>
To: Jan Kara <jack@suse.cz>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] Add possibly missing iput() when quotaon and quotaoff races
Date: Thu, 13 Mar 2008 14:42:11 -0700 [thread overview]
Message-ID: <20080313144211.d32c58f2.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080313120552.GC12523@duck.suse.cz>
On Thu, 13 Mar 2008 13:05:52 +0100
Jan Kara <jack@suse.cz> wrote:
> We should always put inode we have reference to, even if quota was reenabled
> in the mean time.
>
> Signed-off-by: Jan Kara <jack@suse.cz>
>
> ---
> dquot.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/dquot.c b/fs/dquot.c
> index f816d06..24eef58 100644
> --- a/fs/dquot.c
> +++ b/fs/dquot.c
> @@ -1522,8 +1522,8 @@ int vfs_quota_off(struct super_block *sb, int type)
> truncate_inode_pages(&toputinode[cnt]->i_data, 0);
> mutex_unlock(&toputinode[cnt]->i_mutex);
> mark_inode_dirty(toputinode[cnt]);
> - iput(toputinode[cnt]);
> }
> + iput(toputinode[cnt]);
> mutex_unlock(&dqopt->dqonoff_mutex);
> }
> if (sb->s_bdev)
This one looks like 2.6.25 material?
next prev parent reply other threads:[~2008-03-13 21:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-13 12:03 [PATCH 0/3] Quota cleanups and fixes Jan Kara
2008-03-13 12:05 ` [PATCH 1/3] Add possibly missing iput() when quotaon and quotaoff races Jan Kara
2008-03-13 21:42 ` Andrew Morton [this message]
2008-03-17 13:13 ` Jan Kara
2008-03-13 12:06 ` [PATCH 2/3] Remove superfluous DQUOT_OFF() in fs/namespace.c Jan Kara
2008-03-13 12:07 ` [PATCH 3/3] Various style cleanups Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080313144211.d32c58f2.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome