From: Rik van Riel <riel@redhat.com>
To: Roel Kluin <12o3l@tiscali.nl>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
pe1rxq@amsat.org, linux-usb@vger.kernel.org,
video4linux-list@redhat.com, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] logical-bitwise & confusion in se401_init() (was: logical-bitwise & confusion in se401_init()?)
Date: Thu, 13 Mar 2008 17:30:00 -0400 [thread overview]
Message-ID: <20080313173000.5bd1d039@cuia.boston.redhat.com> (raw)
In-Reply-To: <47D94D81.5090108@tiscali.nl>
On Thu, 13 Mar 2008 16:51:29 +0100
Roel Kluin <12o3l@tiscali.nl> wrote:
> - if (!cp[2] && SE401_FORMAT_BAYER) {
> + if (!cp[2] & SE401_FORMAT_BAYER) {
> err("Bayer format not supported!");
> return 1;
> }
Would it be better to put in some additional parenthesis?
if (!(cp[2] & SE401_FORMAT_BAYER)) {
--
All Rights Reversed
next prev parent reply other threads:[~2008-03-13 21:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <47D47257.9090204@tiscali.nl>
[not found] ` <20080313120602.6920a621@gaivota>
2008-03-13 15:51 ` Roel Kluin
2008-03-13 21:30 ` Rik van Riel [this message]
2008-03-13 22:58 ` [PATCH] logical-bitwise & confusion in se401_init() Roel Kluin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080313173000.5bd1d039@cuia.boston.redhat.com \
--to=riel@redhat.com \
--cc=12o3l@tiscali.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=pe1rxq@amsat.org \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®