From: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
To: David Brownell <david-b@pacbell.net>
Cc: kernel@avr32linux.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/10] atmel_serial: Fix build on avr32 with CONFIG_PM enabled
Date: Thu, 13 Mar 2008 21:54:27 +0100 [thread overview]
Message-ID: <20080313215427.0d1a86fc@siona.local> (raw)
In-Reply-To: <200803131337.41337.david-b@pacbell.net>
On Thu, 13 Mar 2008 12:37:40 -0800
David Brownell <david-b@pacbell.net> wrote:
> On Thursday 13 March 2008, Haavard Skinnemoen wrote:
> > AVR32 doesn't have at91_suspend_entering_slow_clock(). Just assume the
> > clock will keep running for now.
>
> Well, it should acquire the clk_must_disable() or somesuch... :)
Indeed. But that interface doesn't exist yet...
> By the way, I noticed a goof in this driver's clock management.
> It should leave the clock off whenever the device isn't open.
> As it is, it wastes power both at runtime and during suspend.
Right. I suspect you'll find a similar goofs in lots of drivers if you
go looking. I intend to go through all the drivers I care about and see
if I can tighten up the clock management a bit. There are probably a
few missing or half-assed suspend/resume implementations around too.
Haavard
next prev parent reply other threads:[~2008-03-13 20:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-13 14:39 [PATCH 00/10] avr32: Power Management support Haavard Skinnemoen
2008-03-13 14:39 ` [PATCH 01/10] mtd: maps/physmap: fix oops in suspend/resume/shutdown ops Haavard Skinnemoen
2008-03-13 14:39 ` [PATCH 02/10] atmel_serial: Fix build on avr32 with CONFIG_PM enabled Haavard Skinnemoen
2008-03-13 14:39 ` [PATCH 03/10] avr32: Move setup_platform() into chip-specific file Haavard Skinnemoen
2008-03-13 14:39 ` [PATCH 04/10] avr32: Rename at32ap.c -> pdc.c Haavard Skinnemoen
2008-03-13 14:39 ` [PATCH 05/10] avr32: Enable SDRAMC clock at startup Haavard Skinnemoen
2008-03-13 14:39 ` [PATCH 06/10] avr32: Add simple SRAM allocator Haavard Skinnemoen
2008-03-13 14:39 ` [PATCH 07/10] macb: Basic suspend/resume support Haavard Skinnemoen
2008-03-13 14:39 ` [PATCH 08/10] avr32: Define TIF_FREEZE Haavard Skinnemoen
2008-03-13 14:39 ` [PATCH 09/10] avr32: Add system device for the internal interrupt controller (intc) Haavard Skinnemoen
2008-03-13 14:39 ` [PATCH 10/10] avr32: Power Management support ("standby" and "mem" modes) Haavard Skinnemoen
2008-03-13 20:18 ` [PATCH 07/10] macb: Basic suspend/resume support David Brownell
2008-03-13 20:28 ` Haavard Skinnemoen
2008-03-13 20:37 ` [PATCH 02/10] atmel_serial: Fix build on avr32 with CONFIG_PM enabled David Brownell
2008-03-13 20:54 ` Haavard Skinnemoen [this message]
2008-03-13 19:26 ` [PATCH 01/10] mtd: maps/physmap: fix oops in suspend/resume/shutdown ops David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080313215427.0d1a86fc@siona.local \
--to=haavard.skinnemoen@atmel.com \
--cc=david-b@pacbell.net \
--cc=kernel@avr32linux.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®