From: Matthew Dharm <mdharm-kernel@one-eyed-alien.net>
To: matthieu castet <castet.matthieu@free.fr>
Cc: linux-usb@vger.kernel.org,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mass storage : emulation of sat scsi_pass_thru with ATACB
Date: Thu, 13 Mar 2008 17:51:39 -0700 [thread overview]
Message-ID: <20080314005139.GP2820@one-eyed-alien.net> (raw)
In-Reply-To: <47D99B01.1030709@free.fr>
[-- Attachment #1: Type: text/plain, Size: 1022 bytes --]
On Thu, Mar 13, 2008 at 10:22:09PM +0100, matthieu castet wrote:
> Matthew Dharm wrote:
> >On Sun, Mar 09, 2008 at 10:42:50PM +0100, matthieu castet wrote:
> >>Hi
> >>
> >>here an update version of the patch
> >
> >We're getting very close here.
> + unsigned char sk, asc, ascq;
> + sk = RECOVERED_ERROR;
> + asc = 0; /* ATA PASS THROUGH INFORMATION AVAILABLE */
> + ascq = 0x1D;
> + /* XXX we should generate sk, asc, ascq from status and error
> + * regs
> + * (see 11.1 Error translation ? ATA device error to SCSI error map)
> + * and ata_to_sense_error from libata.
> + */
> + sb[1] = sk;
> + sb[2] = asc;
> + sb[3] = ascq;
I may have missed this in an earlier patch, but why to you declare and use
these 3 variables like this? Seems odd and confusing to me....
Matt
--
Matthew Dharm Home: mdharm-usb@one-eyed-alien.net
Maintainer, Linux USB Mass Storage Driver
It was a new hope.
-- Dust Puppy
User Friendly, 12/25/1998
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2008-03-14 0:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-08 17:32 matthieu castet
2008-03-08 18:31 ` Matthew Dharm
2008-03-08 20:08 ` matthieu castet
2008-03-08 21:21 ` Matthew Dharm
2008-03-09 8:21 ` matthieu castet
2008-03-09 18:45 ` Matthew Dharm
2008-03-09 21:42 ` matthieu castet
2008-03-10 1:20 ` Matthew Dharm
2008-03-13 21:22 ` matthieu castet
2008-03-14 0:51 ` Matthew Dharm [this message]
[not found] ` <20080318221207.GY2820@one-eyed-alien.net>
2008-03-19 18:40 ` matthieu castet
2008-03-19 20:02 ` Matthew Dharm
2008-03-20 21:39 ` patch usb-mass-storage-emulation-of-sat-scsi_pass_thru-with-atacb.patch added to gregkh-2.6 tree gregkh
2008-03-09 10:13 ` [PATCH] mass storage : emulation of sat scsi_pass_thru with ATACB Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080314005139.GP2820@one-eyed-alien.net \
--to=mdharm-kernel@one-eyed-alien.net \
--cc=castet.matthieu@free.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome