From: Bastian Blank <bastian@waldi.eu.org>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, Zhang Rui <rui.zhang@intel.com>
Subject: [PATCH] THERMAL must not select HWMON
Date: Fri, 14 Mar 2008 19:37:58 +0100 [thread overview]
Message-ID: <20080314183758.GA15028@wavehammer.waldi.eu.org> (raw)
In-Reply-To: <20080314112112.c00cbcdd.rdunlap@xenotime.net>
[-- Attachment #1: Type: text/plain, Size: 862 bytes --]
On Fri, Mar 14, 2008 at 11:21:12AM -0700, Randy Dunlap wrote:
[ select forces HWMON to yes even if deps are never applicable ]
> Yes, that's a known & longstanding problem (that select does not
> follow/honor dependencies).
Okay.
So THERMAL can't select HWMON, instead it needs to do a proper depends.
Bastian
Signed-off-by: Bastian Blank <waldi@debian.org>
Cc: Zhang Rui <rui.zhang@intel.com>
diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
index 3ab313e..394912c 100644
--- a/drivers/thermal/Kconfig
+++ b/drivers/thermal/Kconfig
@@ -4,7 +4,7 @@
menuconfig THERMAL
bool "Generic Thermal sysfs driver"
- select HWMON
+ depends on HWMON
default y
help
Generic Thermal Sysfs driver offers a generic mechanism for
--
You canna change the laws of physics, Captain; I've got to have thirty minutes!
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next parent reply other threads:[~2008-03-14 18:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080314175501.GA11107@wavehammer.waldi.eu.org>
[not found] ` <20080314112112.c00cbcdd.rdunlap@xenotime.net>
2008-03-14 18:37 ` Bastian Blank [this message]
2008-03-14 20:43 ` Andrew Morton
2008-03-14 22:58 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080314183758.GA15028@wavehammer.waldi.eu.org \
--to=bastian@waldi.eu.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®