From: Stefan Bauer <stefan.bauer@cs.tu-chemnitz.de>
To: linux-fbdev-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, Antonino Daplas <adaplas@pol.net>
Subject: [PATCH] i810fb: Fix console switch regression
Date: Sun, 16 Mar 2008 19:42:24 +0100 [thread overview]
Message-ID: <200803161942.24555.stefan.bauer@cs.tu-chemnitz.de> (raw)
From: Stefan Bauer <stefan.bauer@cs.tu-chemnitz.de>
Commit eaa0ff15c30dc9799eb4d12660edb73aeb6d32c5 ("fix ! versus & precedence in
various places") introduced a regression in console switching when using
i810fb. Every 5th to 10th console switch causes 'pixel waste' - the same line
of multi-colored pixels repeated over the whole screen.
This reverts eaa0ff1 for i810_main.c.
Signed-off-by: Stefan Bauer <stefan.bauer@cs.tu-chemnitz.de>
Cc: Antonino Daplas <adaplas@pol.net>
---
As I'm not subscribed to the LKML, please CC me, thanks.
--- linux-2.6/drivers/video/i810/i810_main.c.orig
+++ linux-2.6/drivers/video/i810/i810_main.c
@@ -1476,7 +1476,7 @@ static int i810fb_cursor(struct fb_info
struct i810fb_par *par = info->par;
u8 __iomem *mmio = par->mmio_start_virtual;
- if (!(par->dev_flags & LOCKUP))
+ if (!par->dev_flags & LOCKUP)
return -ENXIO;
if (cursor->image.width > 64 || cursor->image.height > 64)
next reply other threads:[~2008-03-16 19:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-16 18:42 Stefan Bauer [this message]
2008-03-16 19:48 ` [Linux-fbdev-devel] " Geert Uytterhoeven
2008-03-17 8:20 ` Stefan Bauer
2008-03-17 15:41 ` Stefan Bauer
2008-03-18 3:48 ` Andrew Morton
2008-03-18 7:09 ` Stefan Bauer
2008-03-16 19:57 ` Henrique de Moraes Holschuh
2008-03-16 20:02 ` Henrique de Moraes Holschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200803161942.24555.stefan.bauer@cs.tu-chemnitz.de \
--to=stefan.bauer@cs.tu-chemnitz.de \
--cc=adaplas@pol.net \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®