mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michael Hanselmann <linux-kernel@hansmi.ch>
To: Jiri Kosina <jkosina@suse.cz>
Cc: linux-kernel@vger.kernel.org, michel@tungstengraphics.com
Subject: Re: [PATCH] Update key codes for Apple aluminium keyboards
Date: Mon, 17 Mar 2008 21:18:52 +0100	[thread overview]
Message-ID: <20080317201852.GA30667@hansmi.ch> (raw)
In-Reply-To: <Pine.LNX.4.64.0803171759390.30831@jikos.suse.cz>

On Mon, Mar 17, 2008 at 06:00:18PM +0100, Jiri Kosina wrote:
> On Mon, 17 Mar 2008, Michael Hanselmann wrote:
> > After a discussion with the autor of the original patch adding support
> > for Apple's new aluminium keyboards
> > (a45d82d19a6c2a717bcc33cff243199b77fa0082), Michel Dänzer, we decided
> > that some changes should be done.

> Could you please describe the changes in more detailed way, explaining why 
> are they needed, so that we have it in changelog properly? Thanks.

Sure:

---
F5 and F6 have no second function printed on them. Thus their
definitions have been removed from the table.

KEY_CYCLEWINDOWS doesn't name the function of Mac OS X' Exposé properly
and because we couldn't find a better key code, we decided to use
KEY_FN_F4 instead.

We also changed KEY_BACK and KEY_FORWARD, which apply to browser
functions, to KEY_PREVIOUSSONG and KEY_NEXTSONG, since the keys are
intended to control a music player.
---

Does this contain enough details?

Thanks,
Michael

  reply	other threads:[~2008-03-17 20:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-17 16:18 Michael Hanselmann
2008-03-17 17:00 ` Jiri Kosina
2008-03-17 20:18   ` Michael Hanselmann [this message]
2008-03-17 21:21     ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080317201852.GA30667@hansmi.ch \
    --to=linux-kernel@hansmi.ch \
    --cc=jkosina@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michel@tungstengraphics.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®