From: Adrian Bunk <bunk@kernel.org>
To: Thomas Meyer <thomas@m3y3r.de>, lenb@kernel.org
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
htejun@gmail.com, jeff@garzik.org, linux-acpi@vger.kernel.org
Subject: [2.6.25 patch] acpi_drivers.h: fix dock dummy functions
Date: Mon, 17 Mar 2008 22:30:38 +0200 [thread overview]
Message-ID: <20080317203038.GE9550@cs181133002.pp.htv.fi> (raw)
In-Reply-To: <47DEC970.2050402@m3y3r.de>
Built-in code can't use functions in a modular ACPI dock driver.
This patch fixes the following build error reported by Thomas Meyer:
<-- snip -->
...
LD .tmp_vmlinux1
drivers/built-in.o: In function `ata_acpi_associate':
(.text+0x7106a): undefined reference to `register_hotplug_dock_device'
drivers/built-in.o: In function `ata_acpi_associate':
(.text+0x710bd): undefined reference to `register_hotplug_dock_device'
make: *** [.tmp_vmlinux1] Fehler 1
<-- snip -->
Signed-off-by: Adrian Bunk <adrian.bunk@movial.fi>
---
74baa78e04fe0f1aa04d3f09ab63a15da4d92fbd diff --git a/include/acpi/acpi_drivers.h b/include/acpi/acpi_drivers.h
index 9757a04..f70b246 100644
--- a/include/acpi/acpi_drivers.h
+++ b/include/acpi/acpi_drivers.h
@@ -113,7 +113,7 @@ int acpi_processor_set_thermal_limit(acpi_handle handle, int type);
/*--------------------------------------------------------------------------
Dock Station
-------------------------------------------------------------------------- */
-#if defined(CONFIG_ACPI_DOCK) || defined(CONFIG_ACPI_DOCK_MODULE)
+#if defined(CONFIG_ACPI_DOCK) || (defined(CONFIG_ACPI_DOCK_MODULE) && defined (MODULE))
extern int is_dock_device(acpi_handle handle);
extern int register_dock_notifier(struct notifier_block *nb);
extern void unregister_dock_notifier(struct notifier_block *nb);
prev parent reply other threads:[~2008-03-17 20:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-17 19:41 In function `ata_acpi_associate': undefined reference to `register_hotplug_dock_device' Thomas Meyer
2008-03-17 19:48 ` Adrian Bunk
2008-03-17 19:58 ` Thomas Meyer
2008-03-18 3:57 ` Len Brown
2008-03-18 4:11 ` [PATCH] " Len Brown
2008-03-18 6:16 ` Tejun Heo
2008-03-17 20:30 ` Adrian Bunk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080317203038.GE9550@cs181133002.pp.htv.fi \
--to=bunk@kernel.org \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas@m3y3r.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®