From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754674AbYCRDsn (ORCPT ); Mon, 17 Mar 2008 23:48:43 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752659AbYCRDsf (ORCPT ); Mon, 17 Mar 2008 23:48:35 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:41047 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751545AbYCRDse (ORCPT ); Mon, 17 Mar 2008 23:48:34 -0400 Date: Mon, 17 Mar 2008 20:48:12 -0700 From: Andrew Morton To: Stefan Bauer Cc: linux-fbdev-devel@lists.sourceforge.net, Linux Kernel Development , Antonino Daplas Subject: Re: [PATCH] i810fb: Fix console switch regression Message-Id: <20080317204812.2c3e3754.akpm@linux-foundation.org> In-Reply-To: <200803171641.10750.stefan.bauer@cs.tu-chemnitz.de> References: <200803161942.24555.stefan.bauer@cs.tu-chemnitz.de> <200803170920.33626.stefan.bauer@cs.tu-chemnitz.de> <200803171641.10750.stefan.bauer@cs.tu-chemnitz.de> X-Mailer: Sylpheed 2.4.8 (GTK+ 2.12.5; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 17 Mar 2008 16:41:10 +0100 Stefan Bauer wrote: > I'm sorry for the spaces in the second patch, here's a clean one with tabs. > > --- > From: Stefan Bauer > > Since 4c7ffe0b9f7f40bd818fe3af51342f64c483908e ("fbdev: prevent drivers that > have hardware cursors from calling software cursor code") every call of > i810fb_cursor fails with -ENXIO because of a incorrect "!". > > This hasn't striked until eaa0ff15c30dc9799eb4d12660edb73aeb6d32c5 ("fix ! > versus & precedence in various places") surrounded the expression with > braces, so that the intended behavior was inverted. That caused 'pixel > waste' - the same line of multi-colored pixels repeated over the whole > screen - during console switch. > > This switches back to the original pre-4c7ffe0 behavior. > > Signed-off-by: Stefan Bauer > Signed-off-by: Geert Uytterhoeven > Cc: Antonino Daplas > > --- linux-2.6/drivers/video/i810/i810_main.c.orig > +++ linux-2.6/drivers/video/i810/i810_main.c > @@ -1476,7 +1476,7 @@ static int i810fb_cursor(struct fb_info > struct i810fb_par *par = info->par; > u8 __iomem *mmio = par->mmio_start_virtual; > > - if (!(par->dev_flags & LOCKUP)) > + if (par->dev_flags & LOCKUP) > return -ENXIO; > > if (cursor->image.width > 64 || cursor->image.height > 64) Can you please confirm that this actually fixes the bug? That wasn't clear. Thanks.