From: Christoph Hellwig <hch@infradead.org>
To: Jonathan Corbet <corbet@lwn.net>
Cc: linux-kernel@vger.kernel.org, Casey Schaufler <casey@schaufler-ca.com>
Subject: Re: [PATCH] de-semaphorize smackfs
Date: Tue, 18 Mar 2008 03:35:03 -0400 [thread overview]
Message-ID: <20080318073503.GA25958@infradead.org> (raw)
In-Reply-To: <30338.1205795680@vena.lwn.net>
On Mon, Mar 17, 2008 at 05:14:40PM -0600, Jonathan Corbet wrote:
> While looking at the generic semaphore patch, I came to wonder what the
> remaining semaphore users in the kernel were actually doing. After a
> quick grep for down_interruptible(), smackfs remained at the bottom of
> my screen. It seems like a straightforward mutex case - low-hanging
> fruit. So here's a conversion patch; compile-tested only, but what
> could go wrong?
The lock is kept while returning to userspace and could potentially
be release by another process. This is not allowed for mutexes.
next prev parent reply other threads:[~2008-03-18 7:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-17 23:14 Jonathan Corbet
2008-03-18 7:35 ` Christoph Hellwig [this message]
2008-03-18 12:01 ` Ahmed S. Darwish
2008-03-18 15:41 ` Daniel Walker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080318073503.GA25958@infradead.org \
--to=hch@infradead.org \
--cc=casey@schaufler-ca.com \
--cc=corbet@lwn.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®