From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S939121AbYCSXqT (ORCPT ); Wed, 19 Mar 2008 19:46:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758703AbYCSWOW (ORCPT ); Wed, 19 Mar 2008 18:14:22 -0400 Received: from ogre.sisk.pl ([217.79.144.158]:58302 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762426AbYCSWOT (ORCPT ); Wed, 19 Mar 2008 18:14:19 -0400 From: "Rafael J. Wysocki" To: Pavel Machek Subject: Re: suspend slow in 2.6.25-rc6 (was Re: Suspend and hibernation patchset against -rc6) Date: Wed, 19 Mar 2008 23:13:38 +0100 User-Agent: KMail/1.9.6 (enterprise 20070904.708012) Cc: Alexey Starikovskiy , Linus Torvalds , pm list , ACPI Devel Maling List , Alan Stern , David Brownell , Greg KH , Len Brown , LKML , Shaohua Li , Johannes Berg References: <200803172317.33745.rjw@sisk.pl> <200803192259.00091.rjw@sisk.pl> <20080319220210.GG1811@elf.ucw.cz> In-Reply-To: <20080319220210.GG1811@elf.ucw.cz> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200803192313.39664.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, 19 of March 2008, Pavel Machek wrote: > On Wed 2008-03-19 22:58:59, Rafael J. Wysocki wrote: > > On Wednesday, 19 of March 2008, Pavel Machek wrote: > > > > > > > > >> Revert ec.c to 2.6.25-rc5 state: > > > > > >> > > > > > >> * this fixes backlight after closing/reopening the lid while in X on > > > > > >> thinkpad x60 > > > > > >> > > > > > >> * unfortunately it breaks fn-home/end keyboard brightness control > > > > > > It should also break volume up/down/mute keys. Essentially all the keys on Thinkpad. > > > > > > And it would also be regression to 2.6.24 level. > > > > > > > > > > As I explained above. > > > > > > > > > > Unfortunately, applying this means I loose screen as soon as I > > > > > close/reopen lid. 2.6.24 did not behave like that. And it makes my > > > > > machine mostly unusable -- as soon as you try to carry it away, you > > > > > loose video. BAD. > > > > > > > > Can you text the current -git (preferably without anything on top) pretty please? > > > > > > Did anything relevant change in the last 8 hours or so? > > > > No, it didn't. > > > > > My scripts tell me there's nothing to pull: > > > > > > Done counting 441 objects. > > > Result has 304 objects. > > > Deltifying 304 objects. > > > 100% (304/304) done > > > Total 304, written 304 (delta 236), reused 121 (delta 75) > > > Fetching pack (head and objects)... > > > Fetching tags... > > > Up to date. > > > > > > Applying changes... > > > Branch already fully merged. > > > pavel@amd:~$ > > > > Still, the current -git has the offending patch reverted and you're seeing a > > regression nevertheless. > > > > Is that correct? > > Yes. > > (Or more precisely, there are two regressions: > > * s2ram 5 seconds slower -- fixed by current git OK > * backlight goes out in X -- not fixed by current git) Can you please open a bugzilla entry for this one and make it block bug #9832? [That will make the tracking of it a bit easier.] Thanks, Rafael