From: Andrew Morton <akpm@linux-foundation.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: linux-kernel@vger.kernel.org, ketuzsezr@darnok.org
Subject: Re: [mmotm] iscsi_ibft build error
Date: Thu, 20 Mar 2008 15:45:55 -0700 [thread overview]
Message-ID: <20080320154555.2d74c0d5.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080319115655.ff4cb67a.randy.dunlap@oracle.com>
On Wed, 19 Mar 2008 11:56:55 -0700
Randy Dunlap <randy.dunlap@oracle.com> wrote:
> mmotm-2008-0318-1720/drivers/firmware/iscsi_ibft.c: In function 'ibft_show_attribute':
> mmotm-2008-0318-1720/drivers/firmware/iscsi_ibft.c:521: error: implicit declaration of function 'capable'
> mmotm-2008-0318-1720/drivers/firmware/iscsi_ibft.c:521: error: 'CAP_SYS_ADMIN' undeclared (first use in this function)
> mmotm-2008-0318-1720/drivers/firmware/iscsi_ibft.c:521: error: (Each undeclared identifier is reported only once
> mmotm-2008-0318-1720/drivers/firmware/iscsi_ibft.c:521: error: for each function it appears in.)
> make[3]: *** [drivers/firmware/iscsi_ibft.o] Error 1
>
--- a/drivers/firmware/iscsi_ibft.c~scsi-add-iscsi-ibft-support-fix
+++ a/drivers/firmware/iscsi_ibft.c
@@ -65,6 +65,7 @@
#include <linux/blkdev.h>
+#include <linux/capability.h>
#include <linux/ctype.h>
#include <linux/device.h>
#include <linux/err.h>
should do the trick.
Does this driver actually need to run capable(CAP_SYS_ADMIN)? Can we not
rely upon permissions of the reelvant sysfs file?
next prev parent reply other threads:[~2008-03-20 22:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-19 18:56 Randy Dunlap
2008-03-20 22:45 ` Andrew Morton [this message]
2008-03-21 15:41 ` Konrad Rzeszutek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080320154555.2d74c0d5.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ketuzsezr@darnok.org \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome