From: Oleg Nesterov <oleg@tv-sign.ru>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Atsushi Tsuji <a-tsuji@bk.jp.nec.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Roland McGrath <roland@redhat.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH] signals: check_kill_permission: remove tasklist_lock
Date: Fri, 21 Mar 2008 19:10:03 +0300 [thread overview]
Message-ID: <20080321161003.GA1464@tv-sign.ru> (raw)
Now that task_session() can't return a false NULL, check_kill_permission()
doesn't need tasklist_lock.
Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
--- 25/kernel/signal.c~5_CKP_NO_TASKLIST 2008-03-19 21:15:30.000000000 +0300
+++ 25/kernel/signal.c 2008-03-21 18:10:30.000000000 +0300
@@ -551,9 +551,7 @@ static int check_kill_permission(int sig
!capable(CAP_KILL)) {
switch (sig) {
case SIGCONT:
- read_lock(&tasklist_lock);
sid = task_session(t);
- read_unlock(&tasklist_lock);
/*
* We don't return the error if sid == NULL. The
* task was unhashed, the caller must notice this.
reply other threads:[~2008-03-21 16:06 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080321161003.GA1464@tv-sign.ru \
--to=oleg@tv-sign.ru \
--cc=a-tsuji@bk.jp.nec.com \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®