From: Ingo Molnar <mingo@elte.hu>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [patch] forcedeth: fix locking bug with netconsole
Date: Fri, 21 Mar 2008 17:32:54 +0100 [thread overview]
Message-ID: <20080321163252.GA1034@elte.hu> (raw)
In-Reply-To: <47E3DDD1.2010601@pobox.com>
* Jeff Garzik <jgarzik@pobox.com> wrote:
> Ingo Molnar wrote:
>> Subject: forcedeth: fix locking bug with netconsole
>> From: Ingo Molnar <mingo@elte.hu>
>>
>> while using netconsole on forcedeth, lockdep noticed the following
>> locking bug:
> [...]
>> the fix is to disable/restore irqs instead of disable/enable.
>
> So we make _the_ TX fast path slower, to accomodate a path that is
> rarely executed?
no strong opinion but a single PCI mmio access far outweighs any flags
save/restore, so i'd not fight about something like that. I've never
seen flags save/restore costs show up in NMI-driven profiles that had
networking load.
Ingo
prev parent reply other threads:[~2008-03-21 16:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-21 15:52 Ingo Molnar
2008-03-21 16:09 ` Jeff Garzik
2008-03-21 16:32 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080321163252.GA1034@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®