From: Oleg Nesterov <oleg@tv-sign.ru>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
Pavel Emelyanov <xemul@openvz.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH] pids: sys_getsid: make sure we don't return 0 instead of -ESRCH
Date: Sun, 23 Mar 2008 20:51:36 +0300 [thread overview]
Message-ID: <20080323175136.GA3353@tv-sign.ru> (raw)
The task can exit between find_task_by_vpid() and task_session_vnr(), in
that unlikely case sys_getsid() returns 0 instead of -ESRCH.
The bug was introduced by me in ac9a8e3f0f43d20fc316162e8e5f9186d295ff49.
Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
--- 25/kernel/sys.c~1_GETSID 2008-03-20 18:21:17.000000000 +0300
+++ 25/kernel/sys.c 2008-03-23 19:25:36.000000000 +0300
@@ -1019,19 +1019,19 @@ asmlinkage long sys_getsid(pid_t pid)
if (!pid)
return task_session_vnr(current);
else {
- int retval;
+ int retval = 0;
struct task_struct *p;
rcu_read_lock();
p = find_task_by_vpid(pid);
- retval = -ESRCH;
if (p) {
retval = security_task_getsid(p);
if (!retval)
retval = task_session_vnr(p);
}
rcu_read_unlock();
- return retval;
+
+ return retval ?: -ESRCH;
}
}
next reply other threads:[~2008-03-23 17:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-23 17:51 Oleg Nesterov [this message]
2008-03-24 7:39 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080323175136.GA3353@tv-sign.ru \
--to=oleg@tv-sign.ru \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®