mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Jan Engelhardt <jengelh@computergmbh.de>
Cc: linux-kernel@vger.kernel.org
Subject: your old menuconfig patch series, and select
Date: Mon, 24 Mar 2008 01:05:14 -0300	[thread overview]
Message-ID: <20080324040514.GC3321@khazad-dum.debian.net> (raw)

Jan,

In your menuconfig patch series to convert menu into menuconfig,
you used "if <new menuconfig symbol" quite often.

That causes serious issues with "select".  E.g. currently "select
LEDS_CLASS" does not work, because it is inside a "if NEW_LEDS".

Of course, not much stuff is the target of "select", but classes and
their ilk often are.

What's the best solution for this?  Drop the "if <menuconfig symbol>"
and add lots of "depends on <menuconfig symbol>"?  Or hunt down every
symbol selected inside an if and add the required select for the
menuconfig symbol?

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

             reply	other threads:[~2008-03-24  4:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-24  4:05 Henrique de Moraes Holschuh [this message]
2008-03-24  4:47 ` Jan Engelhardt
2008-03-24  6:54   ` Henrique de Moraes Holschuh
2008-03-24 12:32     ` Jan Engelhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080324040514.GC3321@khazad-dum.debian.net \
    --to=hmh@hmh.eng.br \
    --cc=jengelh@computergmbh.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®