From: Randy Dunlap <randy.dunlap@oracle.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: linux-kernel@vger.kernel.org, sam@ravnborg.org
Subject: Re: [PATCH] kbuild: silence documentation GEN xml messages according to $(quiet)
Date: Mon, 24 Mar 2008 09:09:39 -0700 [thread overview]
Message-ID: <20080324090939.73f8b00b.randy.dunlap@oracle.com> (raw)
In-Reply-To: <1206371815-32376-1-git-send-email-vapier@gentoo.org>
On Mon, 24 Mar 2008 11:16:55 -0400 Mike Frysinger wrote:
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
> Documentation/DocBook/Makefile | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/Documentation/DocBook/Makefile b/Documentation/DocBook/Makefile
> index 300e170..f6a4ba3 100644
> --- a/Documentation/DocBook/Makefile
> +++ b/Documentation/DocBook/Makefile
> @@ -186,8 +186,11 @@ quiet_cmd_fig2png = FIG2PNG $@
>
> ###
> # Rule to convert a .c file to inline XML documentation
> + gen_xml = :
> + quiet_gen_xml = echo ' GEN $@'
> +silent_gen_xml = :
> %.xml: %.c
> - @echo ' GEN $@'
> + @$($(quiet)gen_xml)
> @( \
> echo "<programlisting>"; \
> expand --tabs=8 < $< | \
> --
The Makefile changes are good, but the patch description makes it
appear that Mike was rushed. How about something like this?
Add rules for gen_xml and its quiet & silent variants.
This causes "make -s" to be silent for gen_xml.
Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
---
~Randy
next prev parent reply other threads:[~2008-03-24 16:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-24 15:16 Mike Frysinger
2008-03-24 16:09 ` Randy Dunlap [this message]
2008-03-24 16:57 ` Mike Frysinger
2008-04-25 19:00 ` Sam Ravnborg
2008-04-25 19:20 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080324090939.73f8b00b.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®