mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Dave Jones <davej@codemonkey.org.uk>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: Silence two kerneldoc warnings in kernel/audit.c
Date: Mon, 24 Mar 2008 17:33:19 -0700	[thread overview]
Message-ID: <20080324173319.9551cea1.randy.dunlap@oracle.com> (raw)
In-Reply-To: <20080325002705.GA25116@codemonkey.org.uk>

On Mon, 24 Mar 2008 20:27:05 -0400 Dave Jones wrote:

> Silence two kerneldoc warnings.
> 
> Warning(kernel/audit.c:1276): No description found for parameter 'string'
> Warning(kernel/audit.c:1276): No description found for parameter 'len'
> 
> [also fix a typo for bonus points]
> 
> Signed-off-by: Dave Jones <davej@codemonkey.org.uk>

I've sent the same patch to the audit people... so acked-by me.

Good luck.

> --- linux-2.6.24.noarch/kernel/audit.c~	2008-03-24 20:22:32.000000000 -0400
> +++ linux-2.6.24.noarch/kernel/audit.c	2008-03-24 20:23:34.000000000 -0400
> @@ -1269,8 +1269,8 @@ static void audit_log_n_string(struct au
>  
>  /**
>   * audit_string_contains_control - does a string need to be logged in hex
> - * @string - string to be checked
> - * @len - max length of the string to check
> + * @string: string to be checked
> + * @len: max length of the string to check
>   */
>  int audit_string_contains_control(const char *string, size_t len)
>  {
> @@ -1285,7 +1285,7 @@ int audit_string_contains_control(const 
>  /**
>   * audit_log_n_untrustedstring - log a string that may contain random characters
>   * @ab: audit_buffer
> - * @len: lenth of string (not including trailing null)
> + * @len: length of string (not including trailing null)
>   * @string: string to be logged
>   *
>   * This code will escape a string that is passed to it if the string
> 
> --

---
~Randy

      reply	other threads:[~2008-03-25  0:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-25  0:27 Dave Jones
2008-03-25  0:33 ` Randy Dunlap [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080324173319.9551cea1.randy.dunlap@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=davej@codemonkey.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®