From: Andrew Morton <akpm@linux-foundation.org>
To: Benjamin Herrenschmidt <benh@ozlabs.org>
Cc: <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] Give futex init a proper name
Date: Wed, 26 Mar 2008 21:00:38 -0700 [thread overview]
Message-ID: <20080326210038.e54b6180.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080327035249.6F774DDF4D@ozlabs.org>
On Thu, 27 Mar 2008 14:52:15 +1100 Benjamin Herrenschmidt <benh@ozlabs.org> wrote:
> The futex init function is called init(). This is a pain in the neck
> when debugging when you code dies in ... init :-)
>
> This renames it to futex_init().
>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> ---
>
> kernel/futex.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- linux-work.orig/kernel/futex.c 2008-03-27 14:50:11.000000000 +1100
> +++ linux-work/kernel/futex.c 2008-03-27 14:50:20.000000000 +1100
> @@ -2158,7 +2158,7 @@ static struct file_system_type futex_fs_
> .kill_sb = kill_anon_super,
> };
>
> -static int __init init(void)
> +static int __init futex_init(void)
> {
> u32 curval;
> int i;
> @@ -2194,4 +2194,4 @@ static int __init init(void)
>
> return 0;
> }
> -__initcall(init);
> +__initcall(futex_init);
heh, I seem to remember doing about fifty of these in netfilter code a
while back.
You have a way to go - there are thirty-odd just in the crypto code.
next prev parent reply other threads:[~2008-03-27 4:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-27 3:52 Benjamin Herrenschmidt
2008-03-27 4:00 ` Andrew Morton [this message]
2008-03-27 4:53 ` Benjamin Herrenschmidt
2008-03-27 8:12 ` [PATCH] init()/fini() clean up in the crypto Kamalesh Babulal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080326210038.e54b6180.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=benh@ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome