From: Pavel Machek <pavel@ucw.cz>
To: Andi Kleen <andi@firstfloor.org>
Cc: Ingo Molnar <mingo@elte.hu>,
kernel list <linux-kernel@vger.kernel.org>,
Greg KH <greg@kroah.com>, "Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: iommu breaks usb after resume
Date: Thu, 27 Mar 2008 14:29:23 +0100 [thread overview]
Message-ID: <20080327132923.GA12801@elf.ucw.cz> (raw)
In-Reply-To: <20080327114923.GA6589@basil.nowhere.org>
Hi!
> > ...this sounds like it needs to be done during resume, too, no?
>
> This is only a workaround for BIOS that don't set up an aperture,
> but yes if they don't do that it is likely needed on resume too.
>
> You would need to add a resume handler to aperture.c
Probably this needs to be redone during resume, right?
/* Fix up the north bridges */
for (num = 24; num < 32; num++) {
if (!early_is_k8_nb(read_pci_config(0, num, 3, 0x00)))
continue;
/*
* Don't enable translation yet. That is done later.
* Assume this BIOS didn't initialise the GART so
* just overwrite all previous bits
*/
write_pci_config(0, num, 3, 0x90, aper_order<<1);
write_pci_config(0, num, 3, 0x94, aper_alloc>>25);
}
....plus the "enable translation" part... but where is that hiding?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
pomozte zachranit klanovicky les: http://www.ujezdskystrom.info/
next prev parent reply other threads:[~2008-03-27 13:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-20 11:14 Pavel Machek
2008-03-21 13:27 ` Ingo Molnar
2008-03-21 13:54 ` Andi Kleen
2008-03-26 10:21 ` Pavel Machek
2008-03-26 13:00 ` Andi Kleen
2008-03-26 22:54 ` Pavel Machek
2008-03-26 23:00 ` Ingo Molnar
2008-03-26 23:05 ` Pavel Machek
2008-03-27 5:53 ` Andi Kleen
2008-03-27 8:41 ` Pavel Machek
2008-03-27 8:42 ` Pavel Machek
2008-03-27 8:47 ` (eats disks) " Pavel Machek
2008-03-27 9:59 ` Pavel Machek
2008-03-27 11:49 ` Andi Kleen
2008-03-27 13:29 ` Pavel Machek [this message]
2008-03-27 13:34 ` Andi Kleen
2008-03-27 20:30 ` Rafael J. Wysocki
2008-03-27 23:40 ` Pavel Machek
2008-03-27 23:52 ` Rafael J. Wysocki
2008-03-28 13:50 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080327132923.GA12801@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=andi@firstfloor.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®